Skip to content

Split strtr zpp #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Split strtr zpp #12583

merged 1 commit into from
Nov 1, 2023

Conversation

iluuu1994
Copy link
Member

This results in more accurate error messages. The actual motivation is #12461 which avoids replicating the Z_PARAM_ARRAY_HT_OR_STR macro, with a useless array/string check for each overload of the function.

@iluuu1994 iluuu1994 requested a review from bukka as a code owner October 31, 2023 22:23
bukka
bukka approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for master.

@iluuu1994 iluuu1994 merged commit d35faec into php:master Nov 1, 2023
@iluuu1994 iluuu1994 mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @bukka